Skip to content

fix issue 18446 NPE by making sure scoreSupplier.get() returns non-null scorer #19650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix issue 18446 NPE by making sure scoreSupplier.get() returns non-null scorer #19650

wants to merge 2 commits into from

Conversation

haruki1243
Copy link

@haruki1243 haruki1243 commented Oct 16, 2025 •
edited
Loading

Description

fix issue 18446 NPE by making sure scoreSupplier.get() returns non-null scorer

Related Issues

Resolves #[18446]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@haruki1243 haruki1243 requested a review from a team as a code owner October 16, 2025 01:23
@github-actions github-actions bot added bug Something isn't working lucene Search Search query, autocomplete ...etc labels Oct 16, 2025
@haruki1243 haruki1243 changed the title fix issue 18446 NPE by making sure scoreSupplier.get() returns non-nulll scorer fix issue 18446 NPE by making sure scoreSupplier.get() returns non-null scorer Oct 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 19d098a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gaobinlong
Copy link
Contributor

Thanks @haruki1243, the spotlessJavaCheck gradle task failed, please run ./gradlew :server:spotlessApply and then ./gradlew :server:check to make sure the main part of gradle checks can pass. Unit test and yaml rest test are needed, changelog is also needed.

owaiskazi19
owaiskazi19 reviewed Oct 16, 2025
View reviewed changes
server/src/main/java/org/opensearch/common/lucene/search/function/ScriptScoreQuery.java
Weight subQueryWeight = subQuery.createWeight(searcher, subQueryScoreMode, 1.0f);

return new Weight(this) {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would need a test for this change as well

@haruki1243
Copy link
Author

haruki1243 commented Oct 16, 2025 •
edited
Loading

Hi @gaobinlong @owaiskazi19

Thank you so much for your reply. I have made the requested changes, including apotless formatting, tests and changelog

I added test cases to ScriptScoreQueryTests and ScriptScoreQueryIT. both pass. You can try to replace the implementation of ScriptScoreQuery with the old one, and you will see both of them fail.

Regarding yaml rest tests, sorry I didn't find tests that uses script score in those yaml tests, and ScriptScoreQueryIT seems to be the right place for its integration test instead.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 29f7ccd: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@haruki1243
Copy link
Author

❌ Gradle check result for 29f7ccd: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Looks like Jenkins is down

Trigger Jenkins workflows
{"pr_from_sha": "29f7ccd3b63d053ed318383ad421472c90e06991", "pr_from_clone_url": "https://github.com/haruki1243/OpenSearch.git", "pr_to_clone_url": "https://github.com/opensearch-project/OpenSearch.git", "pr_title": "fix issue 18446 npe by making sure scoresupplierget returns nonnull scorer", "pr_number": "19650", "post_merge_action": "false", "pr_owner": "haruki1243"}

<title>403 Forbidden</title>

403 Forbidden

jq: parse error: Invalid numeric literal at line 1, column 7 QUEUE_URL wait for jenkins to start workflow Check if queue exist in Jenkins after triggering Use queue information to find build number in Jenkins if available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@owaiskazi19 owaiskazi19 owaiskazi19 left review comments

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bug Something isn't working lucene Search Search query, autocomplete ...etc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Null pointer exception on a term filter nested inside a script score

3 participants

@haruki1243 @gaobinlong @owaiskazi19